Merged
Conversation
jsmariegaard
approved these changes
Jan 12, 2024
Member
jsmariegaard
left a comment
jsmariegaard
left a comment
There was a problem hiding this comment.
Great stuff! Please just add strategy + example to docstring
| The value to return if strategy is 'constant', by default None | ||
| name : str, optional | ||
| The name of the model result, by default "dummy" | ||
| """ |
Member
There was a problem hiding this comment.
strategy is not documented and please add tiny example also as it is probably not obvious to everyone what this ModelResult is doing :-)
jsmariegaard
approved these changes
Jan 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.